After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782542 - vaapiwindow_x11: invalid src rect info when using vpp in vaapiwindow.
vaapiwindow_x11: invalid src rect info when using vpp in vaapiwindow.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: 1.12.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-12 06:32 UTC by Hyunjun Ko
Modified: 2017-05-12 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libs: window: x11: fix src rect info when using vpp (1.76 KB, patch)
2017-05-12 06:34 UTC, Hyunjun Ko 		committed Details | Review

Description Hyunjun Ko 2017-05-12 06:32:55 UTC 
Since we started using vpp in VaapiWindowX11, we need to care about
the case that src rect and window's size are different.

So, once vpp has converted to other format, we should honor the converted
vpp surface's size as src rect.
Otherwise, it cropped according to previous src rect's size.

We can check this with xdcam-pal-d10-imx30.mxf or op1a-pal-mpeg2.mxf in gst-validate.
Comment 1 Hyunjun Ko 2017-05-12 06:34:26 UTC 
Created attachment 351697 [details] [review]
libs: window: x11: fix src rect info when using vpp

Since we started using vpp in VaapiWindowX11, we need to care about
the case that src rect and window's size are different.

So, once vpp has converted to other format, we should honor the converted
vpp surface's size as src rect.
Otherwise, it cropped according to previous src rect's size.
Comment 2 Víctor Manuel Jáquez Leal 2017-05-12 11:08:25 UTC 
Review of attachment 351697 [details] [review]:

::: gst-libs/gst/vaapi/gstvaapiwindow_x11.c
@@ +40,3 @@
 #include "gstvaapiutils.h"
 #include "gstvaapiutils_x11.h"
+#include "gstvaapisurface_priv.h"

The normal code style is to keep the includes in alphabetical order
Comment 3 Víctor Manuel Jáquez Leal 2017-05-12 14:55:11 UTC 
Attachment 351697 [details] pushed as f09f21d - libs: window: x11: fix src rect info when using vpp
Comment 4 Víctor Manuel Jáquez Leal 2017-05-12 15:34:05 UTC 
branch 1.12

* 7e25936f libs: window: x11: fix src rect info when using vpp