After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782442 - 'command not found' message shown when systemd is not available
'command not found' message shown when systemd is not available
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2017-05-10 14:17 UTC by Ting-Wei Lan
Modified: 2017-05-11 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Avoid running '1' as a command when systemd is not available (1.07 KB, patch)
2017-05-10 14:31 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2017-05-10 14:17:59 UTC
This 'command not found' message is shown when building gvfs on FreeBSD:

checking for SYSTEMD... no
/home/lantw44/gnome/source/gvfs/configure: 1: not found


This doesn't cause any build problem, but I think it is better to avoid executing unknown commands.
Comment 1 Ting-Wei Lan 2017-05-10 14:31:49 UTC
Created attachment 351554 [details] [review]
build: Avoid running '1' as a command when systemd is not available

The ACTION-IF-NOT-FOUND part of PKG_CHECK_MODULES is not needed and we
can simply remove it to avoid the error here. This commit also replaces
PKG_CHECK_MODULES with PKG_CHECK_EXISTS because variables set by
PKG_CHECK_MODULES are not used.
Comment 2 Ondrej Holy 2017-05-11 10:37:42 UTC
Review of attachment 351554 [details] [review]:

Thanks for the patch! Looks good to me!
Comment 3 Ondrej Holy 2017-05-11 10:38:49 UTC
Attachment 351554 [details] pushed as 11481de - build: Avoid running '1' as a command when systemd is not available