After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782269 - week-view: fix signal emission on scrolled_window
week-view: fix signal emission on scrolled_window
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
unspecified
Other All
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-06 15:24 UTC by Mohammed Sadiq
Modified: 2017-05-09 00:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
week-view: fix signal emission on scrolled_window (1.25 KB, patch)
2017-05-06 15:24 UTC, Mohammed Sadiq 		committed Details | Review

Description Mohammed Sadiq 2017-05-06 15:24:47 UTC 
.
Comment 1 Mohammed Sadiq 2017-05-06 15:24:53 UTC 
Created attachment 351263 [details] [review]
week-view: fix signal emission on scrolled_window

This was causing segfault in week-view
Comment 2 Georges Basile Stavracas Neto 2017-05-06 15:30:08 UTC 
Review of attachment 351263 [details] [review]:

Can't you simply pass NULL?
Comment 3 Mohammed Sadiq 2017-05-06 15:49:12 UTC 
(In reply to Georges Basile Stavracas Neto from comment #2)
> Review of attachment 351263 [details] [review] [review]:
> 
> Can't you simply pass NULL?

My be. But this is how it is done in gnome-recipes and gnome-software.
Comment 4 Georges Basile Stavracas Neto 2017-05-06 15:51:09 UTC 
Review of attachment 351263 [details] [review]:

Right. They know what they're doing.

Thanks for the patch.
Comment 5 Georges Basile Stavracas Neto 2017-05-09 00:28:32 UTC 
Attachment 351263 [details] pushed as 178e6a2 - week-view: fix signal emission on scrolled_window