After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782214 - glutils: fix incompatible type issue for set texture target
glutils: fix incompatible type issue for set texture target
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-05 11:26 UTC by kevin
Modified: 2017-05-08 02:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glutils: fix incompatible type issue for set texture target (1.22 KB, patch)
2017-05-05 11:28 UTC, kevin 		none Details | Review

Description kevin 2017-05-05 11:26:15 UTC 
GstGLTextureTarget is enum. Different compile has different define for enum. It is 32 bits on our platform. But below function use 64 bits parameter. It will cause invalid memory access.

gst_gl_value_set_texture_target (value,
        _gst_gl_log2_int64 (target_mask));
Comment 1 kevin 2017-05-05 11:28:42 UTC 
Created attachment 351188 [details] [review]
glutils: fix incompatible type issue for set texture target
Comment 2 Matthew Waters (ystreet00) 2017-05-05 11:37:18 UTC 
How does that produce invalid memory access?

What exactly are you trying to solve?
Comment 3 kevin 2017-05-05 11:49:41 UTC 
we met invalid memory ptr issue with glimagesink plugin. Here is potential issue as the function parameter have incompatible type. _gst_gl_log2_int64() return guint64 while gst_gl_value_set_texture_target() need GstGLTextureTarget which is 32 bits enum.
Comment 4 kevin 2017-05-05 11:54:46 UTC 
The issue will occur when loop playback one 10 seconds stream for 20 hours. The issue is munmap_chunk fail with invalid memory ptr when unref(caps) in glupload stansfer_caps().
Comment 5 Matthew Waters (ystreet00) 2017-05-05 12:28:45 UTC 
And does this fix the issue? I would be very surprised if it does.
Comment 6 kevin 2017-05-05 12:40:58 UTC 
I am verifying it. Will update you next Monday.