After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782157 - decodebin: only the first chain in a chained opus file is played
decodebin: only the first chain in a chained opus file is played
Status: RESOLVED DUPLICATE of bug 782132
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 782095
Blocks:
 
 
Reported: 2017-05-04 11:02 UTC by Vincent Penquerc'h
Modified: 2017-05-05 12:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix chained opus with preskip > packet length (3.22 KB, patch)
2017-05-05 11:51 UTC, Vincent Penquerc'h
none Details | Review

Description Vincent Penquerc'h 2017-05-04 11:02:55 UTC
+++ This bug was initially created as a clone of Bug #782095 +++

jmspeex_:
- Hey, I'm not sure whether this is a problem with totem or whatever backend it    uses, but I have a perfectly audio valid file that crashes totem
- https://jmvalin.ca/misc_stuff/totem_crash2.opus
- This particular file is a chained Opus file, but even without chains, any file with a preskip value larger than one frame causes a crash

I reproduce it with totem 3.24, gstreamer* 1.11.91


The problemes above are now fixed, but the chains beyond the first one still aren't played.

Also the preskip larger than first granpos is not supported by gstreamer.
Comment 1 Vincent Penquerc'h 2017-05-04 11:26:06 UTC
Removing the error case for "preskip larger than first granpos", I can get the whole of the file played, albeit with constant artifacts, presumably at the chain boundaries, since an incorrect amount of samples are likely being removed.
Comment 2 Vincent Penquerc'h 2017-05-05 11:51:37 UTC
Created attachment 351189 [details] [review]
fix chained opus with preskip > packet length

This fixes playback, however I get constant small artifacts, which means the clipping is probably still not quite right.
Comment 3 Vincent Penquerc'h 2017-05-05 12:13:14 UTC
I hadn't seen jmvalin had opened one for this already.

*** This bug has been marked as a duplicate of bug 782132 ***