GNOME Bugzilla – Bug 782063
Fix vaapidecodebin classification to be similar as decodebin
Last modified: 2017-05-10 14:51:49 UTC
Created attachment 350866 [details] [review] It changes plugins classification .
commit 8cbe03599a4f27c2001380e2ec150c4f4267a9cf Author: Victor Toso <me@victortoso.com> Date: Tue May 2 14:08:54 2017 +0200 vaapidecodebin: fix element's classification This bin should have similar classification as decodebin which is "Generic/Bin/Decoder" otherwise it will appear wrongly as video decoder. Signed-off-by: Victor Toso <victortoso@redhat.com> https://bugzilla.gnome.org/show_bug.cgi?id=782063
I had to revert (in extremis) this patch, since it breaks all the playback with vaapisink.
Thanks to Hyunjun for notice it, and a big brown bag for me because I didn't reviewed thoroughly.
(In reply to Víctor Manuel Jáquez Leal from comment #3) > Thanks to Hyunjun for notice it, and a big brown bag for me because I didn't > reviewed thoroughly. Sorry about that, I did not notice any issue here. What would be the right approach for this?
(In reply to Victor Toso from comment #4) > (In reply to Víctor Manuel Jáquez Leal from comment #3) > > Thanks to Hyunjun for notice it, and a big brown bag for me because I didn't > > reviewed thoroughly. > > Sorry about that, I did not notice any issue here. > What would be the right approach for this? Deprecating vaapidecodebin by making decodebin and decodebin3 smart enough to use vaapipostproc when it is neeeded :)
What's the actually purpose of this change though?
(In reply to Tim-Philipp Müller from comment #6) > What's the actually purpose of this change though? AFAIK, to place the element in a different classification, just as decodebin. But it is not related to decodebin at all. It is only a general decoder. Thus I'm closing this bug.