GNOME Bugzilla – Bug 782011
osd slightly misaligned
Last modified: 2018-07-11 11:10:46 UTC
Created attachment 350800 [details] Scaled text - Xorg I have two issues that seem to be linked : - the text seems scaled (Xorg) or blurry (Wayland) - the osd box moves left and right by 1 pixel when increasing or decreasing the volume or brightness The issues only appear on a 1680x1050 screen. The osd is perfect on 1920x1080 and 1280x800 screens.
Created attachment 350801 [details] Blurry text - Wayland
What version of gnome-shell are you using? Bug 772723 and particularly bug 772287 sound related - both fixes are included in 3.22.2.
Gnome 3.22.2 on Fedora 25 bug 772287 is exactly the second bug I described.
(In reply to groucho from comment #3) > Gnome 3.22.2 on Fedora 25 > > bug 772287 is exactly the second bug I described. Except that the fix didn't fix the issue for you :-(
(In reply to Florian Müllner from comment #4) > (In reply to groucho from comment #3) > > Gnome 3.22.2 on Fedora 25 > > > > bug 772287 is exactly the second bug I described. > > Except that the fix didn't fix the issue for you :-( The fix is just a change from Math.floor to Math.ceil. Maybe I am wrong, but to me it looks like it just moves the problem. Having said that, those are not a huge bugs, and 1680x1050 is a rare resolution these days. ;-)
I did some more testing. There is no jitter on a 1080p screen set to 1680x1050 on a desktop PC. When plugged to my laptop and set to 1680x1050, the jitter is there. The desktop PC is running ubuntu gnome 17.04 (gnome 3.24) and has an nvidia card. The laptop has an Intel gpu, and gnome 3.22.2, but I have also tried gnome 3.24 (live images of ubuntu 17.04 and fedora 26 alpha).
Created attachment 352655 [details] [review] osdWindow: fix blurriness at certain resolutions Here is a patch that fixes the blurriness. I think Bug 772287 should be reopened. I'll take a closer look, but I think the problem comes from the level bar. It's width is the white part, which is calculated from the resized OSD, but when it is big enough (around 50%) it also resizes the original OSD from which the resized dimensions are calculated.
Created attachment 352891 [details] [review] osdWindow: change the centering calculation
Created attachment 357988 [details] before and after patch 352655 I hope it isn't a big no-no, but I'm bumping this for a review. At least for the first patch (before/after image attached).
Comment on attachment 352655 [details] [review] osdWindow: fix blurriness at certain resolutions Sorry this feel through the cracks - the first patch is obviously correct, so pushing.
Should we move attachment 352891 [details] [review] to bug 772287, and then can close this one?
Created attachment 372553 [details] [review] osdWindow: change the centering calculation Fixing some extra spaces. Actually, the issue comes from the fact that clutter isn't centering the resized osd. The current solution is trying to cancel this centering and calculating a new one. Which is introducing errors. Also this cancellation would have to be synced with the centering calculation from clutter. The fix I am proposing is taking into account the correct size from the get-go. It is more robust, but it may be still a bit hack-ish (I don't know clutter very much, and I am not sure if it is supposed to center actors before or after they are resized).
Your patch correctly refers to bug 772287, but is attached to the wrong bug here :)
Yes, I didn't know where to put it. I have attached the patch to bug 772287. I guess this one can be closed?
Yeah, see comment 11.
*** This bug has been marked as a duplicate of bug 772287 ***