GNOME Bugzilla – Bug 781902
cally: Fix translation to screen coordinates
Last modified: 2017-05-02 12:31:28 UTC
See patch.
Created attachment 350652 [details] [review] cally: Fix translation to screen coordinates Due to an accidental swap of an else statement and a preprocessor #else, the output x coordinate is currently only set when not using the X11 windowing system, whoops.
Review of attachment 350652 [details] [review]: obviously right :-/
Attachment 350652 [details] pushed as 0fd9e38 - cally: Fix translation to screen coordinates
Created attachment 350685 [details] [review] cally: Fix compilation without X11 backend Commit 0fd9e38175 fixed setting the out parameter for the x coordinate when using the X11 backend, but broke compilation when the backend is not available ... Really fix the issue by running the X11-specific code when the X11 backend is available and in use, and display the one-time warning otherwise.
Meh, sorry I messed this up.
Review of attachment 350685 [details] [review]: *sigh* yeah it seems better this way can you even build without the X backend though?
Attachment 350685 [details] pushed as 9cf8aa4 - cally: Fix compilation without X11 backend I would be surprised if building without the X11 backend worked, but haven't tried. Still, it doesn't feel right to replace one bug with another one :-)