After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781875 - canvas-item: Don't wrap after . immediately followed by numbers
canvas-item: Don't wrap after . immediately followed by numbers
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: All
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-28 00:58 UTC by Jeremy Bicha
Modified: 2017-05-04 08:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
canvas-item: Don't wrap after . immediately followed by numbers (1.73 KB, patch)
2017-04-28 00:58 UTC, Jeremy Bicha 		none Details | Review
canvas-item: Don't wrap after . immediately followed by numbers (2.02 KB, patch)
2017-04-28 13:40 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2017-04-28 00:58:20 UTC 
This was basically already brought up in https://bugzilla.gnome.org/674924 but there was another issue mentioned on that bug that was fixed at the time.

I am hoping that five years later, the maintainer will reconsider.
Comment 1 Jeremy Bicha 2017-04-28 00:58:22 UTC 
Created attachment 350608 [details] [review]
canvas-item: Don't wrap after . immediately followed by numbers

https://launchpad.net/bugs/942539
Comment 2 Carlos Soriano 2017-04-28 07:51:24 UTC 
Review of attachment 350608 [details] [review]:

Sounds reasonable.

Can you expand the commit description before commiting a little? Mentioning more or less the reasoning and what the current code was doing.
Comment 3 Jeremy Bicha 2017-04-28 13:40:31 UTC 
Created attachment 350643 [details] [review]
canvas-item: Don't wrap after . immediately followed by numbers

Nautilus allowed line wrapping for filenames after a . or _
The code made an exception for version numbers, but it
was too rigid and broke things like Ubuntu's 12.04 version
numbering. This relaxes the exception so that the line isn't
wrapped for a . or _ immediately followed by any numbers.

https://launchpad.net/bugs/942539
Comment 4 Carlos Soriano 2017-05-04 08:28:55 UTC 
Review of attachment 350643 [details] [review]:

LGTM thanks! Feel free to backport to any version you are interested in.
Comment 5 Jeremy Bicha 2017-05-04 08:38:24 UTC 
Attachment 350643 [details] pushed as 1ca554b - canvas-item: Don't wrap after . immediately followed by numbers