After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781767 - Wayland: increase key delivery verbosity
Wayland: increase key delivery verbosity
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.22.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-04-26 13:39 UTC by Olivier Fourdan
Modified: 2017-04-28 11:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] wayland: make key event log more explicit (1.42 KB, patch)
2017-04-26 13:41 UTC, Olivier Fourdan 		none Details | Review
[PATCH v2] wayland: make key event log more explicit (1.42 KB, patch)
2017-04-26 14:11 UTC, Olivier Fourdan 		none Details | Review
[PATCH v2] wayland: make key event log more explicit (1.63 KB, patch)
2017-04-26 14:29 UTC, Olivier Fourdan 		committed Details | Review

Description Olivier Fourdan 2017-04-26 13:39:55 UTC 
With Wayland, GDK_DEBUG=events would log key events but not explicitly
    state whether the event is a key press or release, or if it's
    originating from a key repeat.
    
    Add some more verbosity to make sure these informations are logged on
    key delivery when GDK_DEBUG is set.
Comment 1 Olivier Fourdan 2017-04-26 13:41:20 UTC 
Created attachment 350477 [details] [review]
[PATCH] wayland: make key event log more explicit
Comment 2 Olivier Fourdan 2017-04-26 14:11:33 UTC 
Created attachment 350482 [details] [review]
[PATCH v2] wayland: make key event log more explicit

v2: got some format wrong, also add the number of keys being pressed at the time of the event delivery.
Comment 3 Olivier Fourdan 2017-04-26 14:29:05 UTC 
Created attachment 350483 [details] [review]
[PATCH v2] wayland: make key event log more explicit
Comment 4 Matthias Clasen 2017-04-27 19:13:08 UTC 
Review of attachment 350483 [details] [review]:

looks good to me
Comment 5 Olivier Fourdan 2017-04-28 11:30:33 UTC 
Comment on attachment 350483 [details] [review]
[PATCH v2] wayland: make key event log more explicit

attachment 350483 [details] [review] pushed to master as git commit 502e0a3 - wayland: make key event log more explicit

attachment 350483 [details] [review] pushed to branch gtk-3-22 as git commit c770b5c - wayland: make key event log more explicit