After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781539 - ttmlparse: Update tab handling to match clarified intention of TTML spec
ttmlparse: Update tab handling to match clarified intention of TTML spec
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.11.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-20 14:15 UTC by Chris Bass
Modified: 2017-04-20 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
TTML file to demonstrate that tabs aren't suppressed (1008 bytes, text/xml)
2017-04-20 14:15 UTC, Chris Bass
  Details
ttmlparse: Convert tabs to spaces in input (2.44 KB, patch)
2017-04-20 14:17 UTC, Chris Bass
committed Details | Review

Description Chris Bass 2017-04-20 14:15:36 UTC
Created attachment 350132 [details]
TTML file to demonstrate that tabs aren't suppressed

The TTML spec has an issue in which tab (U+0009) characters that are
first in a sequence of whitespace characters are not suppressed at the
start and end of line areas. This issue was reported in [1] and the
editor of the TTML specs confirmed that this was not the intention
behind the spec.

The editor has created an issue to fix this in both the TTML1 and TTML2
specs [2], giving a proposal of what the spec should say. Patch to follow
updates ttmlparse to implement the intended behaviour as proposed, in
which tabs in the input are converted to spaces before processing.

The attached file (tabs.xml) demonstrates that the code at present won't suppress tabs; run as follows:

gst-launch-1.0 ttmlrender name=r videotestsrc pattern="gradient" ! video/x-raw,width=1280,height=720 ! autovideoconvert ! r.video_sink filesrc blocksize=16777216 location=tabs.xml ! ttmlparse ! r.text_sink r. ! ximagesink

[1] https://github.com/w3c/imsc/issues/224
[2] https://github.com/w3c/ttml1/issues/235
Comment 1 Chris Bass 2017-04-20 14:17:41 UTC
Created attachment 350133 [details] [review]
ttmlparse: Convert tabs to spaces in input
Comment 2 Sebastian Dröge (slomo) 2017-04-20 17:50:50 UTC
Attachment 350133 [details] pushed as 9f5e412 - ttmlparse: Convert tabs to spaces in input