GNOME Bugzilla – Bug 781410
nvenc: Various improvements
Last modified: 2018-01-24 10:43:29 UTC
Figured I'd post some patches here as it's been a few years since I last contributed to GStreamer, so I'm feeling a little rusty.
Created attachment 349949 [details] [review] Add support for the Cuda 8.0 SDK
Created attachment 349950 [details] [review] nvenc: Update to the current gstreamer-gl API
Created attachment 349951 [details] [review] nvenc: Add support for I420
Created attachment 349952 [details] [review] nvenc: Add support for dynamic reconfiguration
Created attachment 349953 [details] [review] nvenc: add gop-size property While you're at it, I can add another pending patch of mine here too :)
Created attachment 349956 [details] [review] nvenc: Stop bitstream thread in ::stop()
(In reply to Tim-Philipp Müller from comment #5) > Created attachment 349953 [details] [review] [review] > nvenc: add gop-size property > > While you're at it, I can add another pending patch of mine here too :) Awesome! :)
Hey guys, This is great, GOP was much needed. Question, any plans to add decoder support like NVDEC ?
(In reply to Benjamin from comment #8) > Hey guys, > > This is great, GOP was much needed. > > Question, any plans to add decoder support like NVDEC ? Please file a separate bug for this. I'm not aware of any plans, and NVDEC is a completely different API unfortunately (and requires much deeper CUDA integration). But would be nice to have a plugin for that indeed.
Comment on attachment 349949 [details] [review] Add support for the Cuda 8.0 SDK commit b721a47a50868e32e762cf34639b7ee8dc591fbf Author: Ole André Vadla Ravnås <oleavr@gmail.com> Date: Fri Apr 14 13:57:19 2017 +0200 nvenc: Add support for the Cuda 8.0 SDK https://bugzilla.gnome.org/show_bug.cgi?id=781410
Comment on attachment 349950 [details] [review] nvenc: Update to the current gstreamer-gl API commit 70ac63a97cdcd313796f9f12e367b5bd694ecdde Author: Ole André Vadla Ravnås <oleavr@gmail.com> Date: Fri Apr 14 13:58:21 2017 +0200 nvenc: Update to the current gstreamer-gl API https://bugzilla.gnome.org/show_bug.cgi?id=781410
Comment on attachment 349956 [details] [review] nvenc: Stop bitstream thread in ::stop() commit cb28314013ba7bc495368f97e359c893b640c8c6 Author: Ole André Vadla Ravnås <oleavr@gmail.com> Date: Mon Apr 17 19:25:49 2017 +0200 nvenc: Stop bitstream thread in ::stop() Otherwise we are likely to crash if EOS didn't happen yet. https://bugzilla.gnome.org/show_bug.cgi?id=781410
Comment on attachment 349951 [details] [review] nvenc: Add support for I420 commit bc92b10164e6af68242a7645aa1bc18faf72d77a Author: Ole André Vadla Ravnås <oleavr@gmail.com> Date: Fri Apr 14 15:30:44 2017 +0200 nvenc: Add support for I420 https://bugzilla.gnome.org/show_bug.cgi?id=781410
Comment on attachment 349952 [details] [review] nvenc: Add support for dynamic reconfiguration commit 59365e3d7ba5c6c6c59724401e67e741bb63763c Author: Ole André Vadla Ravnås <oleavr@gmail.com> Date: Mon Apr 17 13:58:53 2017 +0200 nvenc: Add support for dynamic bitrate/preset reconfiguration Useful for dynamically updating bitrate in live scenarios. https://bugzilla.gnome.org/show_bug.cgi?id=781410
Comment on attachment 349953 [details] [review] nvenc: add gop-size property Pushed with minor changes (updated for runtime mutability): commit 07c8417799940da697212246398ffd828f39b169 (HEAD -> master) Author: Tim-Philipp Müller <tim@centricular.com> Date: Sun Apr 16 16:08:27 2017 +0200 nvenc: add "gop-size" property This also changes the default gop size from 30 to 75 frames. https://bugzilla.gnome.org/show_bug.cgi?id=781410
commit bea0ea66be3317728acaa5e501823faa17c06756 Author: Tim-Philipp Müller <tim@centricular.com> Date: Wed Jan 24 10:21:48 2018 +0000 nvenc: mark properties that can be changed at runtime accordingly https://bugzilla.gnome.org/show_bug.cgi?id=781410