After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781391 - wayland/subsurface: Handle clients committing on destroyed subsurface
wayland/subsurface: Handle clients committing on destroyed subsurface
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-04-17 05:31 UTC by Jonas Ådahl
Modified: 2017-04-21 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland/subsurface: Handle clients committing on destroyed subsurface (1.12 KB, patch)
2017-04-17 05:31 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2017-04-17 05:31:00 UTC 
This fixes an issue where Firefox reuses old subsurfaces to show popup menus. Showing popup menus with subsurfaces is wrong, but mutter should still not crash.
Comment 1 Jonas Ådahl 2017-04-17 05:31:05 UTC 
Created attachment 349930 [details] [review]
wayland/subsurface: Handle clients committing on destroyed subsurface

A client can still commit state to a destroyed subsurface. It wont
update anything on the screen, since the subsurface will not be
visible, but mutter should still handle it and not crash.
Comment 2 Rui Matos 2017-04-20 13:00:28 UTC 
Review of attachment 349930 [details] [review]:

looks good
Comment 3 Jonas Ådahl 2017-04-21 09:47:22 UTC 
Attachment 349930 [details] pushed as 704bd4c - wayland/subsurface: Handle clients committing on destroyed subsurface
Comment 4 Jonas Ådahl 2017-04-21 09:48:54 UTC 
Backported to the gnome-3-24 branch.
Comment 5 Jonas Ådahl 2017-04-21 09:49:36 UTC 
Backported to the gnome-3-22 branch.