After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781353 - wayland: presenting maximized window is jittery
wayland: presenting maximized window is jittery
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-04-15 22:06 UTC by Christian Hergert
Modified: 2017-05-22 07:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Hergert 2017-04-15 22:06:11 UTC
When displaying a maximized window, there is a bit of jitter before it stabilizes at the maximized style/positioning.

Test case is basically:

  gtk_window_maximize(win);
  gtk_window_present(win);

But if you want to try some code that is already there: you can play with

 git clone https://github.com/chergert/panel-gtk.git
 cd panel-gtk
 ./autogen.sh
 make
 cd src
 ./test-panel

I'm setting this specifically as a Wayland bug, because I believe that X11 won't really be fixable due to how configure-events are processed w/ the WM.
Comment 1 Christian Hergert 2017-04-15 22:11:47 UTC
I just tested this on Weston and did not have the issue. The application starts at maximized state just fine.

So therefore I'm going to reassign to mutter for now to see if they have any insight.
Comment 2 Olivier Fourdan 2017-05-17 13:03:49 UTC
Can you try with the patch from bug 781353 ?

I suspect this is a bit of the same, the initial showing animation may not play where it should when switching to maximized.
Comment 3 Olivier Fourdan 2017-05-17 13:08:48 UTC
(In reply to Olivier Fourdan from comment #2)
> Can you try with the patch from bug 781353 ?

Oh, I created a circular dependency in bugzilla comments :)

Sorry I meant bug 782183
Comment 4 Christian Hergert 2017-05-18 02:52:29 UTC
Yup this looks great!

I tested with:

  mutter --wayland --nested &
  WAYLAND_DISPLAY=wayland-1 ./test-panel Adwaita.css

using https://github.com/chergert/panel-gtk

Granted I didn't test gnome-shell as a whole, just mutter. But it was broken before the patch and works afterwards.
Comment 5 Olivier Fourdan 2017-05-22 07:31:49 UTC
The fix from bug 782183 also fixes this issue, even though this is not exactly the same issue.

Here, the problem is that mutter would send an xdg_toplevel.configure with a size of 0x0 which causes the client to initially draw its surface with some arbitrary size, causing the apparent jittery.

So for the record:

attachment 351955 [details] [review] pushed to git master as commit 561d71b - wayland: place window if maximized before placement

attachment 351955 [details] [review] pushed to branch gnome-3-24 as commit 7801df7 - wayland: place window if maximized before placement