After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781242 - Require bash in autogen.sh for pushd
Require bash in autogen.sh for pushd
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 776412 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-04-13 00:55 UTC by Philip Chimento
Modified: 2017-04-20 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Require bash for pushd (631 bytes, patch)
2017-04-13 00:55 UTC, Philip Chimento 		committed Details | Review

Description Philip Chimento 2017-04-13 00:55:19 UTC 
Build fix found while rebuilding with jhbuild.
Comment 1 Philip Chimento 2017-04-13 00:55:23 UTC 
Created attachment 349756 [details] [review]
build: Require bash for pushd

If using sh, there's no pushd. Make autogen.sh execute with bash instead.
Comment 2 Philip Chimento 2017-04-13 01:03:51 UTC 
Literally the same patch should be applied to gnome-shell as well, and anywhere else this got copypasta'd :-)
Comment 3 Jonas Ådahl 2017-04-13 02:14:39 UTC 
Review of attachment 349756 [details] [review]:

Looks fairly bashy indeed!
Comment 4 Jonas Ådahl 2017-04-13 02:15:33 UTC 
Attachment 349756 [details] pushed as a4cb1f0 - build: Require bash for pushd
Comment 5 Philip Chimento 2017-04-13 18:03:44 UTC 
OK to commit the same change in gnome-shell? I ran into the same problem there.
Comment 6 Florian Müllner 2017-04-13 18:07:18 UTC 
Yes, though I'm almost sure there's a patch to replace the bashisms on some other bug ...
Comment 7 Philip Chimento 2017-04-15 07:04:48 UTC 
I didn't find it after an admittedly quick search, so I pushed this.
Comment 8 Florian Müllner 2017-04-15 15:40:37 UTC 
Mmh, I thought there was a patch somewhere, but now I only found bug 776412.
Comment 9 Florian Müllner 2017-04-15 15:41:23 UTC 
*** Bug 776412 has been marked as a duplicate of this bug. ***
Comment 10 Ting-Wei Lan 2017-04-20 14:29:50 UTC 
(In reply to Florian Müllner from comment #6)
> Yes, though I'm almost sure there's a patch to replace the bashisms on some
> other bug ...

I found bug 780215, which already has a patch marked as accepted-commit_now. Attachment 349756 [details] doesn't work on FreeBSD because bash is not part of the base system, so its package uses /usr/local/bin/bash.
Comment 11 Florian Müllner 2017-04-20 14:32:36 UTC 
(In reply to Ting-Wei Lan from comment #10)
> I found bug 780215

Ha, that's the one!