After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781234 - the buffer written to by g_input_stream_read is not marked as an out parameter
the buffer written to by g_input_stream_read is not marked as an out parameter
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 774009 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-04-12 19:22 UTC by David Shea
Modified: 2018-05-24 19:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description David Shea 2017-04-12 19:22:00 UTC 
This causes bindings created via gobject-introspection to treat buffer as an input.
Comment 1 Philip Withnall 2017-04-13 09:26:15 UTC 
Fixed in master; the changes will have to be propagated to gobject-introspection for its next release.

8446ee8 ginputstream: Add missing (out) annotations to read() functions
Comment 2 Rico Tzschichholz 2017-05-04 14:42:35 UTC 
This patch doesn't take into account the connection to the length parameters.
Treating these array-parameters as "out" might not be completely correct either.
Comment 3 Philip Withnall 2018-01-04 12:30:33 UTC 
(In reply to Rico Tzschichholz from comment #2)
> This patch doesn't take into account the connection to the length parameters.
> Treating these array-parameters as "out" might not be completely correct
> either.

How does it not take into account the connection to the length parameters? The annotations already have (array length=count). How is (out caller-allocates) not correct? The caller doesn’t pass any information in to g_input_stream_read() in the buffer.

Do you have a suggestion for how to annotate them instead?
Comment 4 Philip Withnall 2018-02-09 11:21:09 UTC 
*** Bug 774009 has been marked as a duplicate of this bug. ***
Comment 5 Philip Withnall 2018-02-09 11:21:38 UTC 
The same annotations are touched in bug #774009, plus some others. The same solution should be applied to all of them.

Rico, what were your concerns here?
Comment 6 GNOME Infrastructure Team 2018-05-24 19:29:02 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1258.