After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781195 - Fix testsuite for GtkPlacesView
Fix testsuite for GtkPlacesView
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-04-11 19:50 UTC by Georges Basile Stavracas Neto
Modified: 2017-04-11 19:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
placesview: fix testsuite (1.19 KB, patch)
2017-04-11 19:50 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Georges Basile Stavracas Neto 2017-04-11 19:50:15 UTC 
Because the network monitor can perfectly be NULL,
the tests were failing on that for GtkPlacesView
always tries to disconnect this handler.

Fix that by only disconnecting the handler when
the network monitor exists.
Comment 1 Georges Basile Stavracas Neto 2017-04-11 19:50:20 UTC 
Created attachment 349695 [details] [review]
placesview: fix testsuite
Comment 2 Matthias Clasen 2017-04-11 19:51:49 UTC 
Review of attachment 349695 [details] [review]:

sure, makes sense
Comment 3 Georges Basile Stavracas Neto 2017-04-11 19:55:02 UTC 
Attachment 349695 [details] pushed as 400db31 - placesview: fix testsuite