After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781162 - Make GtkPlacesView monitor network
Make GtkPlacesView monitor network
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-04-10 22:17 UTC by Georges Basile Stavracas Neto
Modified: 2017-04-10 22:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
places-view: monitor network (3.24 KB, patch)
2017-04-10 22:17 UTC, Georges Basile Stavracas Neto
none Details | Review
places-view: monitor network (3.30 KB, patch)
2017-04-10 22:29 UTC, Georges Basile Stavracas Neto
committed Details | Review

Description Georges Basile Stavracas Neto 2017-04-10 22:17:50 UTC
GtkPlacesView doesn't monitor the network:/// URI, and we have to update it manually to see new network points.

This shouldn't happen.
Comment 1 Georges Basile Stavracas Neto 2017-04-10 22:17:55 UTC
Created attachment 349641 [details] [review]
places-view: monitor network

GtkPlacesView exposes local access points and network
shares transparently by using the 'network:///' URI,
which is handled by GIO.

Currently, however, it doesn't monitor the network
for new available points, such as computers that just
join the network. It may happen too that the backend
won't find all the networks before the network enumeration
finishes.

Fix that by keeping a file monitor inspecting the network
uri, and update the places list when that happens.
Comment 2 Cosimo Cecchi 2017-04-10 22:26:17 UTC
Review of attachment 349641 [details] [review]:

::: gtk/gtkplacesview.c
@@ +918,3 @@
+
+  error = NULL;
+

This is leaked.
Comment 3 Georges Basile Stavracas Neto 2017-04-10 22:29:56 UTC
Created attachment 349642 [details] [review]
places-view: monitor network

GtkPlacesView exposes local access points and network
shares transparently by using the 'network:///' URI,
which is handled by GIO.

Currently, however, it doesn't monitor the network
for new available points, such as computers that just
join the network. It may happen too that the backend
won't find all the networks before the network enumeration
finishes.

Fix that by keeping a file monitor inspecting the network
uri, and update the places list when that happens.
Comment 4 Cosimo Cecchi 2017-04-10 22:32:15 UTC
Review of attachment 349642 [details] [review]:

Looks good to me.
Comment 5 Georges Basile Stavracas Neto 2017-04-10 22:36:28 UTC
Attachment 349642 [details] pushed as 767927a - places-view: monitor network