GNOME Bugzilla – Bug 781162
Make GtkPlacesView monitor network
Last modified: 2017-04-10 22:36:32 UTC
GtkPlacesView doesn't monitor the network:/// URI, and we have to update it manually to see new network points. This shouldn't happen.
Created attachment 349641 [details] [review] places-view: monitor network GtkPlacesView exposes local access points and network shares transparently by using the 'network:///' URI, which is handled by GIO. Currently, however, it doesn't monitor the network for new available points, such as computers that just join the network. It may happen too that the backend won't find all the networks before the network enumeration finishes. Fix that by keeping a file monitor inspecting the network uri, and update the places list when that happens.
Review of attachment 349641 [details] [review]: ::: gtk/gtkplacesview.c @@ +918,3 @@ + + error = NULL; + This is leaked.
Created attachment 349642 [details] [review] places-view: monitor network GtkPlacesView exposes local access points and network shares transparently by using the 'network:///' URI, which is handled by GIO. Currently, however, it doesn't monitor the network for new available points, such as computers that just join the network. It may happen too that the backend won't find all the networks before the network enumeration finishes. Fix that by keeping a file monitor inspecting the network uri, and update the places list when that happens.
Review of attachment 349642 [details] [review]: Looks good to me.
Attachment 349642 [details] pushed as 767927a - places-view: monitor network