After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781098 - --disable-vector-icons started breaking compilation: invert-svg.c:18:21: fatal error: gio/gio.h: No such file or directory
--disable-vector-icons started breaking compilation: invert-svg.c:18:21: fata...
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other Linux
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2017-04-09 16:11 UTC by Sebastian Pipping
Modified: 2017-04-09 23:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Pipping 2017-04-09 16:11:38 UTC 
Hi!


configure.ac fills NATIVE_GLIB_* for --enable-vector-icons only but tools/Makefile.am uses them unconditionally for compilation of invert-svg.  So despite having glib around, compilation fails like this:

  # GEGL="$(which gegl-0.3)" ./autogen.sh --disable-gtk-doc --disable-vector-icons && make -C tools invert-svg
  [..]
  make: Entering directory '/tmp/tmp.u3YpBpZOo6/gimp-GIT/tools'
  gcc -o invert-svg invert-svg.c  
  invert-svg.c:18:21: fatal error: gio/gio.h: No such file or directory
   #include <gio/gio.h>
                       ^
  compilation terminated.
  make: *** [Makefile:1111: invert-svg] Error 1
  make: Leaving directory '/tmp/tmp.u3YpBpZOo6/gimp-GIT/tools'

For the full build log and original bug report please see https://bugs.gentoo.org/show_bug.cgi?id=614914#c7

Best



Sebastian
Comment 1 Jehan 2017-04-09 23:47:45 UTC 
Thanks!
This was a regression from a previous commit.

Fixed with:

commit 5b135406fd2bd097868f117b4e6889e0f18997e8
Author: Jehan <jehan@girinstud.io>
Date:   Mon Apr 10 01:41:27 2017 +0200

    Bug 781098 - only build invert-svg with --enable-vector-icons.
    
    This is a regression introduced in commit 84439a8 (partially reverted
    in commit 9a2da53 but some pieces were missing!).

 tools/Makefile.am | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)