After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781082 - When installing directly to system, systemd unit file is not installed
When installing directly to system, systemd unit file is not installed
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-09 05:22 UTC by DJ Lucas
Modified: 2017-04-19 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix Makefile.am test (714 bytes, patch)
2017-04-09 05:22 UTC, DJ Lucas 		none Details | Review
Fix installation of gdm unit on system (non-DESTDIR) installation (1.33 KB, patch)
2017-04-19 06:25 UTC, DJ Lucas 		committed Details | Review

Description DJ Lucas 2017-04-09 05:22:19 UTC 
Created attachment 349541 [details] [review]
fix Makefile.am test

Logic in Makefile.am is incorrect. When installing directly, rather than using DESTDIR, check for the systemd unit directory negates installation of the unit file itself. Separate the checks. Sorry for the duplicate as I filed both here and on github as pull request. HACKING file also needs to be updated with the correct process.
Comment 1 Ray Strode [halfline] 2017-04-18 18:19:56 UTC 
hey do you mind doing this as git format-patch -1 ? that way commit message and preferred authorship information are included in the patch.
Comment 2 DJ Lucas 2017-04-19 06:25:44 UTC 
Created attachment 350046 [details] [review]
Fix installation of gdm unit on system (non-DESTDIR) installation

Sure thing. Thanks. Apologies for the incorrect format.
Comment 3 Ray Strode [halfline] 2017-04-19 14:05:14 UTC 
Thanks! pushed with minor changes.