After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 781037 - videoaggregator: Do not mix the same buffer twice when EOS.
videoaggregator: Do not mix the same buffer twice when EOS.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.11.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-07 16:53 UTC by Mathieu Duponchelle
Modified: 2017-04-07 18:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videoaggregator: Do not mix the same buffer twice when EOS. (1.09 KB, patch)
2017-04-07 16:53 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2017-04-07 16:53:06 UTC 
When entering this code path, we know that:

We received EOS on this pad.
We consumed all its buffers.

In any case, we want to replace vaggpad->buffer with NULL,
otherwise we will end up mixing the same buffer twice.
Comment 1 Mathieu Duponchelle 2017-04-07 16:53:12 UTC 
Created attachment 349495 [details] [review]
videoaggregator: Do not mix the same buffer twice when EOS.
Comment 2 Thibault Saunier 2017-04-07 16:54:54 UTC 
Review of attachment 349495 [details] [review]:

Looks correct
Comment 3 Mathieu Duponchelle 2017-04-07 16:57:14 UTC 
Attachment 349495 [details] pushed as 4d63aee - videoaggregator: Do not mix the same buffer twice when EOS.