GNOME Bugzilla – Bug 781029
sunset and sunrise assets fuzzy on HiDPI
Last modified: 2017-04-10 09:58:45 UTC
Created attachment 349458 [details] fuzzy icons The icons for sunset and sunrise do exists in the symbolic theme as daytime-sunrise-symbolic and daytime-sunset-symbolic, however the display panel ships them as png resources. They get fuzzy on HiDPI as the attched screenshot demonstrates.
Created attachment 349464 [details] [review] Load appropriate assets for the night light panel We hard-code a 16x16 asset for sunrise and sunset icons, which makes them look blurry at higher scaling factors. Let's look in the icon theme to see if there's an icon for sunrise and sunset; if not, we can still use the assets we ship, but we also attempt to load them from different resource paths, depending on the scale factor. We will need to update the assets to include a 32x32 rendering of the sunrise and sunset icons.
Created attachment 349465 [details] [review] Load appropriate assets for the night light panel We hard-code a 16x16 asset for sunrise and sunset icons, which makes them look blurry at higher scaling factors. Let's look in the icon theme to see if there's an icon for sunrise and sunset; if not, we can still use the assets we ship, but we also attempt to load them from different resource paths, depending on the scale factor. We will need to update the assets to include a 32x32 rendering of the sunrise and sunset icons.
Review of attachment 349465 [details] [review]: Code looks good. Please prefix the commit subject with the panel name, in this case display: Not sure if this is a UI break and thus may go to the 3.24 branch
Created attachment 349483 [details] Using Adwaita assets
Pushed to master, after updating the commit message.
(In reply to Rui Matos from comment #3) > Not sure if this is a UI break and thus may go to the 3.24 branch I don't think it's a UI break: the icon is part of Adwaita for that specific reason, and the fallback asset in place in case the theme does not have the icon is the same. At most, you'll experience the same bug if: - you don't use Adwaita - your icon theme does not provide daytime-sunset/daytime-sunrise symbolic icons - you are using HiDPI resolutions Ideally, we should ship a new 32x32 fallback asset, but that can be introduced in master and we can discuss the backport to the gnome-3-24 branch.
I'll poke the release team by Monday, so we can decide to backport by the time we need a g-c-c release for 3.24.1.
With my release team hat on, I don't think this is a ui break, and I have no objections to putting this into 3.24.1
Thanks. I've cherry-picked the fix to gnome-3-24.