After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780966 - aacparse: streamline and improve AudioSpecificConfig parsing
aacparse: streamline and improve AudioSpecificConfig parsing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-04-06 10:04 UTC by Edward Hervey
Modified: 2017-04-06 10:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
aacparse: streamline and improve AudioSpecificConfig parsing (6.02 KB, patch)
2017-04-06 10:04 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2017-04-06 10:04:44 UTC 
See commit message
Comment 1 Edward Hervey 2017-04-06 10:04:48 UTC 
Created attachment 349348 [details] [review]
aacparse: streamline and improve AudioSpecificConfig parsing

AudioSpecifigConfig is used in a variety of AAC streams but was
being parsed differently. Instead, make everyone use the same parsing.

* Remove unused 'bits' field (it was always set to 0 if present)
* Add proper GAConfig parsing (to know the  number of samples per frame
  if present).

Fixes wrong rate/channels configuration in streams coming from qtdemux
Comment 2 Edward Hervey 2017-04-06 10:10:17 UTC 
commit 9a066e548ddd6da12de29bd8cfe2f084767c2e82
Author: Edward Hervey <edward@centricular.com>
Date:   Thu Apr 6 12:01:00 2017 +0200

    aacparse: streamline and improve AudioSpecificConfig parsing
    
    AudioSpecifigConfig is used in a variety of AAC streams but was
    being parsed differently. Instead, make everyone use the same parsing.
    
    * Remove unused 'bits' field (it was always set to 0 if present)
    * Add proper GAConfig parsing (to know the  number of samples per frame
      if present).
    
    Fixes wrong rate/channels configuration in streams coming from qtdemux
    
    https://bugzilla.gnome.org/show_bug.cgi?id=780966