After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780768 - Build failure in GNOME Continuous
Build failure in GNOME Continuous
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: documentation
Git master
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-31 14:32 UTC by Emmanuele Bassi (:ebassi)
Modified: 2017-04-01 08:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Avoid some new deprecation warnings (1.33 KB, patch)
2017-04-01 08:16 UTC, Christoph Reiter (lazka)
committed Details | Review

Description Emmanuele Bassi (:ebassi) 2017-03-31 14:32:01 UTC
Deprecated API usage causes a build failure.

Full build failure log:

http://build.gnome.org/continuous/buildmaster/builds/2017/03/31/28/build/log-pygobject.txt

Continuous builds with the default flags, which means we get the blunt of the -Werror mallet; you may want to consider running without -Werror by default instead.
Comment 1 Christoph Reiter (lazka) 2017-03-31 20:03:02 UTC
Thanks. I assumed that we should enable -Werror by default for non-releases when reading https://wiki.gnome.org/Projects/GnomeCommon/Migration
Comment 2 Emmanuele Bassi (:ebassi) 2017-03-31 20:34:35 UTC
In general, yes; in practice, I think a blanket -Werror only makes sense for the maintainers, unless you're also willing to keep an eye on Continuous once you pushed commits to master, in order to fix fallout.

In this specific case, GObject introduced new deprecated API, which causes pygobject to fail to build.
Comment 3 Christoph Reiter (lazka) 2017-04-01 08:16:43 UTC
Created attachment 349105 [details] [review]
Avoid some new deprecation warnings
Comment 4 Christoph Reiter (lazka) 2017-04-01 08:20:51 UTC
I didn't see any obvious way to change the default behavior there, except marking every build as release. I'm open to suggestions.