After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780764 - video-converter: fix scaler leak
video-converter: fix scaler leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-31 13:13 UTC by Vincent Penquerc'h
Modified: 2017-03-31 15:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
video-converter: fix scaler leak (1.42 KB, patch)
2017-03-31 13:14 UTC, Vincent Penquerc'h 		none Details | Review
video-converter: fix scaler leak (951 bytes, patch)
2017-03-31 13:57 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2017-03-31 13:13:16 UTC 
video-converter: fix scaler leak
Comment 1 Vincent Penquerc'h 2017-03-31 13:14:30 UTC 
Created attachment 349044 [details] [review]
video-converter: fix scaler leak
Comment 2 Sebastian Dröge (slomo) 2017-03-31 13:40:25 UTC 
Review of attachment 349044 [details] [review]:

::: gst-libs/gst/video/video-converter.c
@@ +2546,2 @@
   for (i = 0; i < 4; i++) {
+    for (j = 0; j < n_threads; j++) {

There are not as many scalers as there are CPUs. This is actually a bug in setup_scale(), it should use the number of threads as configured on convert->conversion_runner
Comment 3 Vincent Penquerc'h 2017-03-31 13:57:10 UTC 
Created attachment 349054 [details] [review]
video-converter: fix scaler leak
Comment 4 Vincent Penquerc'h 2017-03-31 15:20:04 UTC 
commit 32ef8f54d4728da465bfd20456e22d182a822570
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Mar 31 13:43:52 2017 +0100

    video-converter: fix scaler leak
    
    https://bugzilla.gnome.org/show_bug.cgi?id=780764