After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780705 - Can't view any comics in Books
Can't view any comics in Books
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: books
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Books Maintainers
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-29 21:00 UTC by Bastien Nocera
Modified: 2017-03-30 02:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
evince: Fix assertions trying to view comics (1.16 KB, patch)
2017-03-29 21:01 UTC, Bastien Nocera 		none Details | Review

Description Bastien Nocera 2017-03-29 21:00:15 UTC 
Broken by 7b1a8fdc41ae9525b2c2f4ca421f27a7dbf9e744

(org.gnome.Books:30031): Gjs-WARNING **: JS ERROR: Exception in callback for signal: window-mode-changed: TypeError: action is null
EvinceViewToolbar<._addFullscreenButton@resource:///org/gnome/Books/js/evinceview.js:752

and

(org.gnome.Books:3069): Gjs-WARNING **: JS ERROR: Exception in callback for signal: window-mode-changed: TypeError: action is null
EvinceViewToolbar<._fullscreenStateChanged@resource:///org/gnome/Books/js/evinceview.js:759

Wrong fix attached.
Comment 1 Bastien Nocera 2017-03-29 21:01:23 UTC 
Created attachment 348954 [details] [review]
evince: Fix assertions trying to view comics
Comment 2 Cosimo Cecchi 2017-03-30 02:25:19 UTC 
Thanks, I pushed a proper fix.