After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780616 - buildmanager: add install action
buildmanager: add install action
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: libide
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-27 19:37 UTC by Christian Hergert
Modified: 2017-03-29 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build-manager: Add install action (2.63 KB, patch)
2017-03-28 07:52 UTC, Umang Jain 		none Details | Review
build-manager: Add install action (1.66 KB, patch)
2017-03-28 10:43 UTC, Umang Jain 		committed Details | Review

Description Christian Hergert 2017-03-27 19:37:11 UTC 
Sometimes it might be useful to directly activate the install phase from the command bar.

Add a new "install" action to libide/buildsystem/ide-build-manager.c. (You'll see other actions like "build" and "clean" already in there).

It should just need to call:

  ide_build_manager_execute_async() with IDE_BUILD_PHASE_INSTALL
Comment 1 Umang Jain 2017-03-28 07:52:52 UTC 
Created attachment 348865 [details] [review]
build-manager: Add install action
Comment 2 Christian Hergert 2017-03-28 09:10:13 UTC 
Review of attachment 348865 [details] [review]:

I don't think installing (without running the project) is a common enough task to warrant putting into the omnibar. So just go ahead and drop the ide-omni-bar.ui hunk from the patch and then this looks good to go.

In the future we might consider adding something in the hamburger menu for all the build stages, but not until we think that through.
Comment 3 Umang Jain 2017-03-28 10:43:18 UTC 
Created attachment 348879 [details] [review]
build-manager: Add install action
Comment 4 Christian Hergert 2017-03-29 17:43:00 UTC 
Review of attachment 348879 [details] [review]:

LGTM, thanks!
Comment 5 Christian Hergert 2017-03-29 17:58:09 UTC 
Attachment 348879 [details] pushed as 1ca13d1 - build-manager: Add install action