Bug 780508 – documents: Warn that DocCommon implementations must override load

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 780508 - documents: Warn that DocCommon implementations must override load


Summary:	documents: Warn that DocCommon implementations must override load


Status:	RESOLVED FIXED

Product:	gnome-documents
Classification:	Core
Component:	general
Version:	3.24.x
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME documents maintainer(s)
QA Contact:	GNOME documents maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2017-03-24 18:26 UTC by Debarshi Ray
Modified:	2017-03-26 23:49 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
documents: Warn that DocCommon implementations must override load (783 bytes, patch) 2017-03-24 18:26 UTC, Debarshi Ray	committed	Details \| Review

Description Debarshi Ray 2017-03-24 18:26:01 UTC

See patch.

Just a nicety and for the sake of completeness. By the way, what do you think of throwing an actual exception instead of just logging an error message when such assertions are hit? It might be more expressive.

Comment 1 Debarshi Ray 2017-03-24 18:26:50 UTC

Created attachment 348665 [details] [review]
documents: Warn that DocCommon implementations must override load

Comment 2 Cosimo Cecchi 2017-03-26 08:14:10 UTC

Review of attachment 348665 [details] [review]:

Thanks, looks good.
I also agree your suggestion of throwing an error in these cases.

Comment 3 Debarshi Ray 2017-03-26 23:49:34 UTC

Thanks for the review!