After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780478 - v4l2object: add videometa if there is padding to the right and bottom
v4l2object: add videometa if there is padding to the right and bottom
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.10.4
Other Linux
: Normal normal
: 1.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-23 21:12 UTC by Carlos Rafael Giani
Modified: 2017-03-24 18:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for extending the padding check (1.08 KB, patch)
2017-03-23 21:14 UTC, Carlos Rafael Giani
committed Details | Review

Description Carlos Rafael Giani 2017-03-23 21:12:52 UTC
v4l2object only adds videometa if necessary. It performs several checks to see if the videometa is actually needed. One of these checks sees if there is padding present. However, at the moment, it only looks at the top and left borders for padding - not at the right and bottom ones.

The result is that pipelines like this one produce incorrect results:

  videotestsrc ! "video/x-raw, format=I420, width=480, height=270" ! x264enc ! v4l2videoNdec

Since 270 is not a multiple of 16, x264 will add 2 padding rows to the bottom. And since v4l2object ignores these padding rows, it will not add a videometa, even though it is actually needed to inform downstream about the correct plane offsets with the padding included.
Comment 1 Carlos Rafael Giani 2017-03-23 21:14:24 UTC
Created attachment 348606 [details] [review]
Patch for extending the padding check
Comment 2 Nicolas Dufresne (ndufresne) 2017-03-24 18:00:53 UTC
Also in 1.10

commit cebf961dd53e38fb01420c6b20d6804ea69920cf
Author: Carlos Rafael Giani <dv@pseudoterminal.org>
Date:   Thu Mar 23 22:13:05 2017 +0100

    v4l2object: Also add videometa if there is padding to the right and bottom
    
    https://bugzilla.gnome.org/show_bug.cgi?id=780478