After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780471 - appinfo: Only use portal as fallback
appinfo: Only use portal as fallback
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-03-23 19:30 UTC by Florian Müllner
Modified: 2017-03-25 21:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
appinfo: Only use portal as fallback (2.00 KB, patch)
2017-03-23 19:30 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-03-23 19:30:15 UTC 
See patch.

This allows handling user documentation in flatpak without any special-casing by the application.
Comment 1 Florian Müllner 2017-03-23 19:30:20 UTC 
Created attachment 348601 [details] [review]
appinfo: Only use portal as fallback

We currently assume that the OpenURI portal should be used
unconditionally when running inside a flatpak sandbox. While
the portal is what we usually want, there are exceptions:
Yelp is now included in the GNOME runtime to allow displaying
help without exporting the user documentation, and the sandboxed
app itself may register a scheme handler.
To account for those cases transparently, always try the normal
code path first and only fall back to calling the portal when
that fails.
Comment 2 Matthias Clasen 2017-03-25 21:35:17 UTC 
Review of attachment 348601 [details] [review]:

ok
Comment 3 Florian Müllner 2017-03-25 21:46:44 UTC 
Attachment 348601 [details] pushed as 05f0d81 - appinfo: Only use portal as fallback