GNOME Bugzilla – Bug 780374
Don't reset search results when searching for "Later alternatives" fails
Last modified: 2017-06-10 16:55:39 UTC
Currently, when no results are found during a route search, the result list is reset to an empty state. This is also done if the user performs a transit search and already got some results and then tries to load later (or earlier) alternatives and none are found, in this case the previous results are cleared. We should probably instead show a notification informing that no furher results could be found and keep the old results (maybe hide the "Load later alternatives" row?).
Created attachment 348533 [details] [review] transitPlan: Add a signal for no more alternatives This signal will be emitted when the user searches for later or earlier transit itineraries and none are found to intstruct the interface to retain previous results.
Created attachment 348534 [details] [review] openTripPlanner: Indicate no more results found When doing a query for later or earlier alternatives, and no more itineraries where found, signal to the transit plan that no more results are available.
Created attachment 348535 [details] [review] sidebar: Hide load more results row when no more available When no later or earlier transit itineraries where found, hide the row to load more results.
This does the trick for me. One small UI fix that would improve this would be to show the error "No later routes found" inline in the sidebar itself, but I want to file that as a separate issue, since it generally works like it should in this bug, and it will need some design
Just noticed you get very funny results if you add a 3rd address as a via point and try to "Load more..." when there are no more available. It will suddenly erase the via point and show only the route between the initial addresses.
Attachment 348533 [details] pushed as e15043c - transitPlan: Add a signal for no more alternatives Attachment 348534 [details] pushed as 9daa6cb - openTripPlanner: Indicate no more results found Attachment 348535 [details] pushed as ddb5517 - sidebar: Hide load more results row when no more available
I think the issue with the via point is unrelated to this (I think I even saw that with walking or car routing at some point). So I'm pushing this now, and we can see later on if we refine the UI in a subsequent bug, this behavior is at least better than currently when just resetting all the old results.
Filed a followup about that issue as bug #783634