After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780369 - gstpython: Meson fails to find pythondetector
gstpython: Meson fails to find pythondetector
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other Linux
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-21 18:30 UTC by Nicolas Dufresne (ndufresne)
Modified: 2017-03-24 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: Install in gi._overidesdir only if we are installing in right prefix (4.79 KB, patch)
2017-03-23 15:12 UTC, Thibault Saunier
none Details | Review

Description Nicolas Dufresne (ndufresne) 2017-03-21 18:30:11 UTC
Meson does not check if pythondetector is installed. This lead to wrong installation path.
Comment 1 Nicolas Dufresne (ndufresne) 2017-03-21 18:31:29 UTC
For the rereference I ended up with

prefix/_gi_gst.cpython-35m-x86_64-linux-gnu.so
prefix/lib64/gstreamer-1.0/libgstpythonplugin.so
prefix/Gst.py
prefix/GstPbutils.py
Comment 2 Thibault Saunier 2017-03-21 20:01:51 UTC
Well, how does it not find it if it is inside the folder itself?
Comment 3 Nicolas Dufresne (ndufresne) 2017-03-22 12:03:17 UTC
Rephrased, it fails, and it's a bug.
Comment 4 Thibault Saunier 2017-03-23 00:55:34 UTC
It fails at  detecting the script? Or what is failing exactly?
Comment 5 Thibault Saunier 2017-03-23 00:55:57 UTC
It fails at  detecting the script? Or what is failing exactly?
Comment 6 Nicolas Dufresne (ndufresne) 2017-03-23 13:38:47 UTC
To reproduce:

mkdir build
cd build
meson .. --prefix=/your/prefix
ninja-build install

I didn't yet have time to investigate, I just switched to autotool to finish my work. I simply guessed the script was not found, but it would also be returning an empty string. I have no idea how this thing works, I have not yet looked at it. If you can't reproduce, I guess I'll have a look. But I think my way of using it is closer to what packages and cross-compilation will do.
Comment 7 Thibault Saunier 2017-03-23 15:12:50 UTC
Created attachment 348579 [details] [review]
meson: Install in gi._overidesdir only if we are installing in right prefix

And make sure python detector did not fail

I am not sure it will solve the issue but this sound much saner to me.
Comment 8 Thibault Saunier 2017-03-24 15:39:51 UTC
commit 7f78ed2541d7671bee2198ca45c556897c3ff060
Author: Thibault Saunier <thibault.saunier@osg.samsung.com>
Date:   Thu Mar 23 12:09:05 2017 -0300

    meson: Install in gi._overidesdir only if we are installing in right prefix
    
    And make sure python detector did not fail
    
    https://bugzilla.gnome.org/show_bug.cgi?id=780369