After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780352 - Do not fail when there's no empty line after headers
Do not fail when there's no empty line after headers
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
2.57.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2017-03-21 13:19 UTC by Carlos Garcia Campos
Modified: 2017-08-07 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (2.55 KB, patch)
2017-03-21 13:22 UTC, Carlos Garcia Campos 		none Details | Review
Can you try this version and make sure it still makes the tests pass? (2.31 KB, patch)
2017-05-01 16:57 UTC, Dan Winship 		committed Details | Review

Description Carlos Garcia Campos 2017-03-21 13:19:13 UTC 
The spec says there should be an empty line (\r\n) between the response headers and the body. However, some servers don't include the empty line when the response doesn't have a body. This is causing several WebKit tests to fail, because some of the imported w3c tests do not include that empty line. Those tests pass in firefox, chromium and safari, so at least those other browsers allow that.
Comment 1 Carlos Garcia Campos 2017-03-21 13:22:03 UTC 
Created attachment 348411 [details] [review]
Patch

Not including tests this time because I don't know if this can be tested with SoupServer.
Comment 2 Dan Winship 2017-05-01 16:57:08 UTC 
Created attachment 350811 [details] [review]
Can you try this version and make sure it still makes the tests pass?
Comment 3 Carlos Garcia Campos 2017-05-03 17:04:17 UTC 
Unfortunately the tests have changed and no longer timeout even without the patch, but it seems we get the same result with this version and mine, so I assume it's fine. Thanks!
Comment 4 Carlos Garcia Campos 2017-07-10 12:56:35 UTC 
Dan, are you going to land your patch then?