GNOME Bugzilla – Bug 780347
rtpmux output PTS are not in line with the DTS and the segment
Last modified: 2017-03-24 09:12:07 UTC
Created attachment 348394 [details] [review] rtpmux: fix output segment and buffer DTS to correspond to the flattened PTS rtpmux flattens out all buffer PTS to running time, however the buffer DTS remains the same and also the output segment is copied from one of the sink pads, without any logic. This patch is an attempt to fix this. It converts the DTS also to running time and pushes out a newly initialized segment instead of a random upstream one.
Review of attachment 348394 [details] [review]: Note the DTS can be negative, not sure if it applies to this case, but this patch will output TIME_NONE DTS if it's the case. (not necessarily a problem, I'm letting you judge)
Review of attachment 348394 [details] [review]: I'm not sure you need to rsend the segment event in those places. The rtpmux creates its own segment independent from the inputs. I'm not sure if negative DTS is really a real world concern for RTP but it would be a bit tricky unless we just add a fixed reasonable offset in the segment and offset back it off to 0.
(In reply to Olivier Crête from comment #2) > I'm not sure you need to rsend the segment event in those places. The rtpmux > creates its own segment independent from the inputs. No, it doesn't. That's the main bug. My intention is not to re-send the segment, but merely to just send a correct segment while avoiding the propagation of the upstream one.
commit 501bf0e8d144515a743c00d325af84c9f38cb5c0 Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Tue Mar 21 12:54:27 2017 +0200 rtpmux: fix output segment and buffer DTS to correspond to the flattened PTS https://bugzilla.gnome.org/show_bug.cgi?id=780347