After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780256 - Add Screenshot function
Add Screenshot function
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.23.x
Other Linux
: Normal enhancement
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-19 02:40 UTC by Jeremy Bicha
Modified: 2017-06-05 08:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
actions-popover: Add "Take Screenshot" action (2.53 KB, patch)
2017-03-20 10:03 UTC, Felipe Borges
committed Details | Review
actions-popover: Add screenshot flash feedback (1.64 KB, patch)
2017-03-20 12:16 UTC, Felipe Borges
committed Details | Review
screencast (506.21 KB, video/webm)
2017-03-20 12:18 UTC, Felipe Borges
  Details
gnome-photos-crop (494.51 KB, video/webm)
2017-03-20 17:28 UTC, Felipe Borges
  Details

Description Jeremy Bicha 2017-03-19 02:40:50 UTC
VirtualBox has a Screenshot button (View>Take Screenshot). I think it would be nice if Boxes had this too.
Comment 1 Felipe Borges 2017-03-20 10:03:14 UTC
Created attachment 348299 [details] [review]
actions-popover: Add "Take Screenshot" action

This feature allows screenshots to be easily taken in the display
mode.

The resulting png files are stored in the user's pictures folder,
named with the same format as gnome-settings-daemon screenshots:
_("Screenshot from %Y-%m-%d %H-%M-%S").
Comment 2 Felipe Borges 2017-03-20 12:16:53 UTC
Created attachment 348309 [details] [review]
actions-popover: Add screenshot flash feedback

Currently there's no visual feedback when taking a screenshot.

This patch introduces a css-based visual effect of a camera
"flash".
Comment 3 Felipe Borges 2017-03-20 12:18:23 UTC
Created attachment 348310 [details]
screencast
Comment 4 Jeremy Bicha 2017-03-20 15:28:09 UTC
oooh, you spelled out Windows 10!

Thanks for the screencast! It looks great. :)

I wonder if it should work more like gnome-screenshot's interactive mode which shows you a thumbnail while prompting you what to name the screenshot.
Comment 5 Felipe Borges 2017-03-20 17:28:17 UTC
Created attachment 348337 [details]
gnome-photos-crop

(In reply to Jeremy Bicha from comment #4)
> oooh, you spelled out Windows 10!
> 
> Thanks for the screencast! It looks great. :)
> 
> I wonder if it should work more like gnome-screenshot's interactive mode
> which shows you a thumbnail while prompting you what to name the screenshot.

Yep, that would be a good evolution of this code.

I guess we could get the basic functionality in, and then design something more customizable.

I would like to be able to:

1. Select the path/destination;
2. *Crop* just a part of the screenshot (like gnome-photos).

jimmac, what do you think?
Comment 6 Jeremy Bicha 2017-03-20 17:36:17 UTC
(In reply to Felipe Borges from comment #5)
> I guess we could get the basic functionality in, and then design something
> more customizable.

+1
Comment 7 Felipe Borges 2017-06-05 08:15:31 UTC
Let's open a new bug when there will be a plan to add more features to the screenshot option.

Attachment 348299 [details] pushed as 449b86c - actions-popover: Add "Take Screenshot" action
Attachment 348309 [details] pushed as a19745c - actions-popover: Add screenshot flash feedback