After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780155 - [review] lr/rp-filter: Neuter the IPv4 Reverse Path filter when it's known to drop legitimate traffic
[review] lr/rp-filter: Neuter the IPv4 Reverse Path filter when it's known to...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2017-03-16 15:41 UTC by Lubomir Rintel
Modified: 2017-03-22 11:23 UTC
See Also:
GNOME target: ---
GNOME version: ---



Comment 1 Thomas Haller 2017-03-16 18:05:49 UTC
pushed minor fixups.

the patch will reset the sysctl on every route change. That seems excessive.
Also, I think the device should only reset the default when NM itself change it.
Comment 2 Lubomir Rintel 2017-03-17 19:11:23 UTC
Applied the fixups, updated the branch.
Comment 3 Francesco Giudici 2017-03-21 14:51:54 UTC
lgtm
Comment 4 Lubomir Rintel 2017-03-22 11:23:53 UTC
edaa7d064e5efef2abcb08d44355a2a8f5a09e87