After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780108 - dashdemux: invalid enum conversion in SIDX seek error handling
dashdemux: invalid enum conversion in SIDX seek error handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-15 19:53 UTC by Scott D Phillips
Modified: 2017-03-16 10:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Scott D Phillips 2017-03-15 19:53:17 UTC 
This patch introduces some assignments of one enum type into a
variable of a different enum type:

> 141f3b2 dashdemux: If a SIDX seek failed although we're in the correct segment, disable the SIDX usage for this segment

Which causes this compile failure due to warnings:

../subprojects/gst-plugins-bad/ext/dash/gstdashdemux.c:1350:42: error: implicit conversion from enumeration type 'GstIsoffParserResult' to different enumeration type 'GstSidxParserStatus' (aka 'enum _GstSidxParserStatus') [-Werror,-Wenum-conversion]                                                                                                
        dashstream->sidx_parser.status = GST_ISOFF_PARSER_UNEXPECTED;
                                       ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../subprojects/gst-plugins-bad/ext/dash/gstdashdemux.c:2290:47: error: implicit conversion from enumeration type 'GstIsoffParserResult' to different enumeration type 'GstSidxParserStatus' (aka 'enum _GstSidxParserStatus') [-Werror,-Wenum-conversion]                                                                                                
            dash_stream->sidx_parser.status = GST_ISOFF_PARSER_UNEXPECTED;
                                            ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../subprojects/gst-plugins-bad/ext/dash/gstdashdemux.c:2774:49: error: implicit conversion from enumeration type 'GstIsoffParserResult' to different enumeration type 'GstSidxParserStatus' (aka 'enum _GstSidxParserStatus') [-Werror,-Wenum-conversion]                                                                                                
              dash_stream->sidx_parser.status = GST_ISOFF_PARSER_UNEXPECTED;
                                              ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~

I'm not sure what the right value is instead of GST_ISOFF_PARSER_UNEXPECTED,
maybe GST_ISOFF_SIDX_PARSER_FINISHED?
Comment 1 Sebastian Dröge (slomo) 2017-03-15 21:47:27 UTC 
Thanks, will handle this tomorrow
Comment 2 Sebastian Dröge (slomo) 2017-03-16 10:36:15 UTC 
commit 7e21168d4d27be5afe8431fc209255494594c639
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Mar 16 12:35:40 2017 +0200

    dashdemux: Just reset SIDX parser if the index is invalid for the current segment
    
    https://bugzilla.gnome.org/show_bug.cgi?id=780108