After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 780063 - gdm: Handle absence of Fprint.Manager service
gdm: Handle absence of Fprint.Manager service
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-14 21:01 UTC by Florian Müllner
Modified: 2017-03-22 13:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gdm: Handle absence of Fprint.Manager service (1.75 KB, patch)
2017-03-14 21:01 UTC, Florian Müllner 		none Details | Review
gdm: Handle absence of Fprint.Manager service (2.19 KB, patch)
2017-03-20 15:02 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-03-14 21:01:14 UTC 
See patch.
Comment 1 Florian Müllner 2017-03-14 21:01:20 UTC 
Created attachment 347952 [details] [review]
gdm: Handle absence of Fprint.Manager service

We rely on the service to detect whether a fingerprint reader is
present. It is fine to not support fingerprint authentication
when the service is missing, but currently we don't handle this
case at all and end up with a non-functional login screen.
Comment 2 Rui Matos 2017-03-15 12:33:06 UTC 
Review of attachment 347952 [details] [review]:

looks good
Comment 3 Florian Müllner 2017-03-20 15:02:45 UTC 
Created attachment 348323 [details] [review]
gdm: Handle absence of Fprint.Manager service

I didn't test this properly before - if we want to return null, we cannot instantiate with new ...
Comment 4 Rui Matos 2017-03-20 15:16:38 UTC 
Review of attachment 348323 [details] [review]:

oops, good catch
Comment 5 Florian Müllner 2017-03-20 18:14:17 UTC 
Attachment 348323 [details] pushed as c0861b1 - gdm: Handle absence of Fprint.Manager service
Comment 6 Ray Strode [halfline] 2017-03-22 13:26:16 UTC 
interesting. I guess bug 675006 never worked or got regressed by bug 683131