After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779959 - typedefs: fix type information.
typedefs: fix type information.
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: g-ir-scanner
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-13 02:44 UTC by Mathieu Duponchelle
Modified: 2017-03-14 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
typedefs: fix type information. (2.77 KB, patch)
2017-03-13 02:44 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2017-03-13 02:44:03 UTC 
We now reuse _create_type_from_base instead of reimplementing
it in a semi-broken way in transformer, and use complete_ctype
when writing it out if available.

This incidentally allows us to remove a test where the comment
acknowledged the non-optimal behaviour.
Comment 1 Mathieu Duponchelle 2017-03-13 02:44:07 UTC 
Created attachment 347780 [details] [review]
typedefs: fix type information.
Comment 2 Emmanuele Bassi (:ebassi) 2017-03-14 11:42:32 UTC 
Review of attachment 347780 [details] [review]:

Looks good.

Are there any changes in the generated GIR for GLib/GObject in tree?
Comment 3 Mathieu Duponchelle 2017-03-14 16:23:42 UTC 
(In reply to Emmanuele Bassi (:ebassi) from comment #2)
> Review of attachment 347780 [details] [review] [review]:
> 
> Looks good.
> 
> Are there any changes in the generated GIR for GLib/GObject in tree?

None in GObject, two in GLib:

 meh   master  ⋯  gnome  sources  gobject-introspection  diff new_glib.gir GLib-2.0.gir 
29c29
<       <type name="none" c:type="void"/>
---
>       <type name="gpointer" c:type="gpointer"/>
49c49
<       <type name="utf8" c:type="gchar**"/>
---
>       <type name="gpointer" c:type="gpointer"/>
Comment 4 Mathieu Duponchelle 2017-03-14 16:51:38 UTC 
Attachment 347780 [details] pushed as df019eb - typedefs: fix type information.