GNOME Bugzilla – Bug 779898
weather: Handle GeoClue not responding
Last modified: 2017-03-11 19:53:42 UTC
Created attachment 347703 [details] [review] weather: Handle GeoClue not responding Sometimes GeoClue seems to be unresponsive which causes gnome-shell to display the weather of New York City, regardless of the most recently used location in gnome-weather which is supposed to be used as a fallback. I have not yet investigated what causes the issue on the GeoClue side. What happens in gnome-shell is that the callback of Geoclue.Simple.new is never being called due to GeoClue being stuck. This means that _gclueFailed remains false, despite GeoClue not responding. The fallback code however checks for _gclueFailed and only sets the location if GeoClue has failed. Because neither code path actually sets a location in this case, the default location of gweather is being used instead, which happens to be New York City.
Review of attachment 347703 [details] [review]: Alternatively, we could all relocate to New York City ... ::: js/misc/weather.js @@ +166,2 @@ if (this._useAutoLocation) { + this._startGClueService(); Style nit: Remove braces now that both blocks have just one line
Attachment 347703 [details] pushed as ce5875f - weather: Handle GeoClue not responding