After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779872 - weather: Provide weather_*_to_string_full() variants
weather: Provide weather_*_to_string_full() variants
Status: RESOLVED FIXED
Product: libgweather
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: future
Assigned To: libgweather-maint
libgweather-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-10 18:04 UTC by Florian Müllner
Modified: 2017-08-20 13:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
weather: Provide weather_*_to_string_full() variants (20.02 KB, patch)
2017-03-10 18:04 UTC, Florian Müllner 		committed Details | Review
weather: Fix inconsistent capitalization (910 bytes, patch)
2017-03-11 18:04 UTC, Florian Müllner 		committed Details | Review
weather: Don't CamelCase user-visible strings (1.24 KB, patch)
2017-03-11 18:04 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2017-03-10 18:04:13 UTC 
This came up when integrating weather information in gnome-shell, see bug 754031 (particularly https://bugzilla.gnome.org/show_bug.cgi?id=754031#c21 and https://bugzilla.gnome.org/show_bug.cgi?id=754031#c28).
Comment 1 Florian Müllner 2017-03-10 18:04:17 UTC 
Created attachment 347661 [details] [review]
weather: Provide weather_*_to_string_full() variants

Strings returned by the various weather_*_to-string() functions
use sentence capitalization, which isn't always desirable. For
the case where the strings are meant to be used within a sentence,
add _full variants that take an additional flags parameter that
allows requesting those.
Comment 2 Florian Müllner 2017-03-11 18:04:45 UTC 
Created attachment 347717 [details] [review]
weather: Fix inconsistent capitalization

All condition strings use sentence capitalization, except for a single
case of header capitalization.
Comment 3 Florian Müllner 2017-03-11 18:04:51 UTC 
Created attachment 347718 [details] [review]
weather: Don't CamelCase user-visible strings

Some wind directions like "northeast" are currently using CamelCase,
while others don't. Use the correct form consistently.
Comment 4 Piotr Drąg 2017-08-03 12:42:24 UTC 
The next string freeze is approaching; I would really love to see this in 3.26.
Comment 5 Giovanni Campagna 2017-08-20 13:24:27 UTC 
Attachment 347661 [details] pushed as f39ee8b - weather: Provide weather_*_to_string_full() variants
Attachment 347717 [details] pushed as 008987a - weather: Fix inconsistent capitalization
Attachment 347718 [details] pushed as 9634dbe - weather: Don't CamelCase user-visible strings