GNOME Bugzilla – Bug 779855
shmsrc: add uri handler
Last modified: 2018-11-03 14:05:40 UTC
Created attachment 347640 [details] [review] Add simple URI interface Add uri handler (shm://)
Review of attachment 347640 [details] [review]: ::: sys/shm/gstshmsrc.c @@ +485,3 @@ +gst_shm_src_uri_get_uri (GstURIHandler * handler) +{ + return NULL; I'm pretty sure we can do better than returning NULL here. @@ +506,3 @@ + } + + if (gst_uri_query_has_key (gst_uri, "socket-path")) { Any reason to put the socket path as a key instead of shm:///path/to/socket ?
(In reply to Olivier Crête from comment #1) > + if (gst_uri_query_has_key (gst_uri, "socket-path")) { > > Any reason to put the socket path as a key instead of shm:///path/to/socket ? Bug #779765 I guess, but this should definitely be part of the path instead here.
It would be more clean if the socket path is in the path part of the URI. I will rewrite the patch. It it depends on the uri parsing bug; it will not break the previous functionality.
I a bit in doubt as how to continue. In most of our patches, we add a PROP_URI next to the Uri interface. Since this results in keeping a GstUri *uri variable; there is no longer need for a socket_path property. Maybe that would be better to be a second patch on top of this one.
Created attachment 347841 [details] [review] rework
Review of attachment 347841 [details] [review]: ::: sys/shm/gstshmsrc.c @@ +242,3 @@ + gchar *string = gst_uri_to_string (self->uri); + + g_value_set_string (value, string); g_value_take_string().
Created attachment 347913 [details] [review] g_value_take_string
Review of attachment 347913 [details] [review]: ::: sys/shm/gstshmsrc.c @@ +146,3 @@ + g_object_class_install_property (gobject_class, PROP_URI, + g_param_spec_string ("uri", "URI", "URI grab from", Maybe a better description like "URI of socket from shmsink"
Created attachment 374058 [details] [review] [PATCH] Add uri handler for shmsrc
improved description to "URI of socket for shmsrc"
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/531.