After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779827 - Brushes in Symmetry Tiling mode are off by one pixel
Brushes in Symmetry Tiling mode are off by one pixel
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2017-03-10 01:06 UTC by unascribed
Modified: 2017-03-10 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description unascribed 2017-03-10 01:06:21 UTC 
Symmetry Tiling mode appears to have a minor bug; when clicking with the Pencil tool, the drawn area is 1 pixel right and 1 pixel down from where the mouse was clicked. Sometimes it's only off in one direction. The Brush tool on radius 1 always draws a 2x2 box. (Maybe it's off by half a pixel?)

This isn't really noticeable with larger brush sizes, but when doing pixel art it makes the symmetry tiling tool nigh-unusable.

Mirror and Mandala modes seem unaffected.

Video: https://unascribed.com/v/e411cc0b.mp4

Commit 8ca855d (git master at time of posting), built from the AUR - https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=gimp-git
Comment 1 unascribed 2017-03-10 01:09:28 UTC 
It looks like the commit I built is actually 8e68ca85 - the first three characters got truncated in the version string somehow. I'd imagine this is an issue with the PKGBUILD and not GIMP, but adding the note since I got the hash wrong in the first comment.
Comment 2 Jehan 2017-03-10 01:44:19 UTC 
Hi! I'll have a look. Thanks for the report.
Comment 3 Jehan 2017-03-10 03:28:09 UTC 
Fixed.

commit 22247339ce0203163f139b161f260eab42f185ef
Author: Jehan <jehan@girinstud.io>
Date:   Fri Mar 10 03:56:57 2017 +0100

    Bug 779827 - Brushes in Symmetry Tiling mode are off by one pixel.
    
    Computation for tiled brush position has to be done in integer, not
    double, to avoid funky type conversion rounding.
Comment 4 unascribed 2017-03-10 13:08:52 UTC 
Great, thanks for the quick fix! Keep up the good work.