After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779800 - wayland: dnd from java to wayland native get through and end up in another window underneath
wayland: dnd from java to wayland native get through and end up in another wi...
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
3.23.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-09 10:26 UTC by Olivier Fourdan
Modified: 2017-03-09 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] xwayland: Raise the dnd window each time (1.24 KB, patch)
2017-03-09 13:13 UTC, Olivier Fourdan
committed Details | Review

Description Olivier Fourdan 2017-03-09 10:26:45 UTC
Description:

Follow-up on bug 779757 and bug 763246, using DnD from a Java application (Xwayland) onto a native Wayland application will get through the Wayland native window and end up in some other Xwayland window underneath.

How reproducible:

Only the first time, further DnD work

Steps to reproduce:

1. Have 3 windows as follow:

  +---------------+
  |  Java Window  |---+
  |               |   |
  |               |   |---+
  |               |   |   |
  +---------------+   |   |
     | Wayland native |   |
     +----------------+   |
        | Xwayland window |
        +-----------------+

2. Select some text in the Java window and drop it onto the Wayland
   native window

Actual result:

The Dnd ends unp in the XWayland window placed underneath. Again, this is for the first DnD atttempt only.
Comment 1 Olivier Fourdan 2017-03-09 13:13:37 UTC
Created attachment 347557 [details] [review]
[PATCH] xwayland: Raise the dnd window each time

If the dnd window ends up lower in the overall stack than the window
it's supposed to fence, the drop might end up in some other window
underneath the expected target window.

Maps and raises the dnd window each time it's shown so that it's always
placed above.
Comment 2 Carlos Garnacho 2017-03-09 13:15:37 UTC
Review of attachment 347557 [details] [review]:

Indeed, quite an oversight...
Comment 3 Olivier Fourdan 2017-03-09 13:22:35 UTC
Comment on attachment 347557 [details] [review]
[PATCH] xwayland: Raise the dnd window each time

attachment 347557 [details] [review] pushed to git master as commit 4b86af8 - xwayland: Raise the dnd window each time