After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779700 - Printer panel layout improvements
Printer panel layout improvements
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
git master
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-07 12:08 UTC by Allan Day
Modified: 2017-03-10 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
printers: improve panel layout (3.00 KB, patch)
2017-03-07 12:10 UTC, Allan Day 		none Details | Review
printers: improve panel layout (2.83 KB, patch)
2017-03-07 16:44 UTC, Allan Day 		committed Details | Review

Description Allan Day 2017-03-07 12:08:04 UTC 
There are some minor layout issues with the new printer panel:

 * Printer icons are a bit big, which leads to spacing being too tight.
 * Unequal spacing at the top of each printer row.
 * Name and status strings are a little close together.
 * Print queue and gear buttons are a bit close.
 * Error messages need separating from the information above.
Comment 1 Allan Day 2017-03-07 12:10:05 UTC 
Created attachment 347385 [details] [review]
printers: improve panel layout
Comment 2 Marek Kašík 2017-03-07 16:35:00 UTC 
Hi Allan, thank you for the patch. I actually like the big icons there but if you think that they should be smaller then lets change them but I would like to have the name of the printer a little bit bigger. What about 1.2x intead of the original 1.5x?
Comment 3 Allan Day 2017-03-07 16:44:03 UTC 
Created attachment 347409 [details] [review]
printers: improve panel layout

OK.
Comment 4 Marek Kašík 2017-03-09 11:53:33 UTC 
Review of attachment 347409 [details] [review]:

Thank you for the change. Please ask for freeze break if you want to get it to the 3.24 release.
Comment 5 Felipe Borges 2017-03-10 15:21:17 UTC 
Thanks Allan!

The freeze exception was accepted:
https://mail.gnome.org/archives/gnome-doc-list/2017-March/msg00010.html

Attachment 347409 [details] pushed as 3fe69f0 - printers: improve panel layout
Comment 6 Felipe Borges 2017-03-10 15:24:59 UTC 
Attachment 347409 [details] pushed as aa2b98b (master) - printers: improve panel layout