After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779594 - tests: Don't fail when Gtk+-4.0 is available
tests: Don't fail when Gtk+-4.0 is available
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Florian Müllner
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2017-03-04 23:02 UTC by Florian Müllner
Modified: 2017-03-08 06:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tests: Don't fail when Gtk+-4.0 is available (963 bytes, patch)
2017-03-04 23:02 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2017-03-04 23:02:39 UTC
Drive-by fix when working on bug 779593, see patch.
Comment 1 Florian Müllner 2017-03-04 23:02:43 UTC
Created attachment 347238 [details] [review]
tests: Don't fail when Gtk+-4.0 is available

We currently link with Gtk+-3.0, so that is the only version we can
import without conflicts. As without version, gobject-introspection
will pick the latest available version and Gtk+-4.0 may now be
available, we thus need to explicitly request the correct version.
Comment 2 Philip Chimento 2017-03-05 21:15:21 UTC
Review of attachment 347238 [details] [review]:

+1
Comment 3 Florian Müllner 2017-03-05 22:32:37 UTC
Attachment 347238 [details] pushed as 6f283b0 - tests: Don't fail when Gtk+-4.0 is available