GNOME Bugzilla – Bug 779532
emptying the shopping list should leave the page
Last modified: 2017-03-04 17:39:40 UTC
the 'clear list' button removes all recipes from the shopping list and goes back to the landing page. removing the recipes one-by-one by using remove in their menu, on the other hand, leaves you on the shopping list page, with a somewhat awkward empty state. I think we should go back to the overview in that case too.
Created attachment 347186 [details] [review] Checks for the condition of empty shopping list and if true, goes back to home page
Review of attachment 347186 [details] [review]: Good work. The code looks fine and works great in my brief testing. But lets improve the commit message a bit. I would keep the subject line shorter and use what you have there now as the body. Also, leave out the [PATCH] marker. Like: Subject: Don't show an empty shopping list Leave the shopping page and go back to the home page when the last recipe is removed from the shopping list. This matches the behavior of the "Clear List" button.
(In reply to Matthias Clasen from comment #2) > Review of attachment 347186 [details] [review] [review]: > > Good work. The code looks fine and works great in my brief testing. > But lets improve the commit message a bit. I would keep the subject > line shorter and use what you have there now as the body. > Also, leave out the [PATCH] marker. > > Like: > > Subject: Don't show an empty shopping list > > Leave the shopping page and go back to the home page > when the last recipe is removed from the shopping list. > This matches the behavior of the "Clear List" button. Thanks Mr. Clasen. I'll rebase it and attach a patch with better commit message.
Created attachment 347216 [details] [review] Don't show an empty shopping list
Review of attachment 347216 [details] [review]: Very good. I'll merge this now