After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779366 - incorrect finish function for Pixbuf.from_stream_at_scale_async
incorrect finish function for Pixbuf.from_stream_at_scale_async
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
0.35.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-28 12:01 UTC by Michael Gratton
Modified: 2017-02-28 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Revert the finish function change (1.27 KB, patch)
2017-02-28 12:17 UTC, Michael Gratton 		none Details | Review
gdk-pixbuf-2.0: Use correct finish-func for Pixbuf.from_stream_at_scale_async() (2.71 KB, patch)
2017-02-28 15:21 UTC, Rico Tzschichholz 		committed Details | Review

Description Michael Gratton 2017-02-28 12:01:55 UTC 
Commit f52b4849 introduced a bug when using Pixbuf.from_stream_at_scale_async; the finish should have remained gdk_pixbuf_new_from_stream_finish, not changed to gdk_pixbuf_save_to_stream_finish.

This is causing a crash in the current master Flatpak build of Geary.
Comment 1 Michael Gratton 2017-02-28 12:17:32 UTC 
Created attachment 346900 [details] [review]
Revert the finish function change

Seems to work fine for me with this.
Comment 2 Rico Tzschichholz 2017-02-28 15:21:44 UTC 
Created attachment 346906 [details] [review]
gdk-pixbuf-2.0: Use correct finish-func for Pixbuf.from_stream_at_scale_async()
Comment 3 Rico Tzschichholz 2017-02-28 16:11:01 UTC 
Attachment 346906 [details] pushed as 4f5213a - gdk-pixbuf-2.0: Use correct finish-func for Pixbuf.from_stream_at_scale_async()