GNOME Bugzilla – Bug 779346
Week View: Incorrect starting day of the week in certain locales
Last modified: 2017-03-02 10:22:12 UTC
Created attachment 346882 [details] Weeks start with Sunday in locales with Monday as starting day In locales where Monday is the starting day of the week, such as en_GB, the week view still displays Sunday as the first day. Which in turn results in Bug 777762 (https://bugzilla.gnome.org/show_bug.cgi?id=777762), where all days are off-by-one, such as 2nd Jan 2017 is shown to be a Sunday, whereas it should have been a Monday.
I guess this is because of me. Please set the first weekday of week header while you are setting the first weekday for week view. That should fix it :)
Gollapudi, can you submit a patch for this?
Created attachment 346995 [details] [review] Patch for the bug I think this should work, please check the patch.
Review of attachment 346995 [details] [review]: The code is great, and the commit message is very good too - congratulations! Can you please also call gcal_week_grid_set_first_weekday() here? So we set both the header and the grid. I'm marking this patch as 'needs-work' for you to put the Grid function there too, then we're good to go. Thanks for working on that!
Created attachment 347016 [details] [review] Week-view: the first weekday is set for week-header & week-grid In this commit, the first weekday is set for week-header & week-grid. The issue is, the first weekday is being set only for week-view, resulting in incorrect display of weekdays in the week-header. To fix this, the first weekday for week-header & week-grid is set along with that of week-view.
Thanks for the patch. Pushed with a couple of nitpicks fixed (commit message, space after macros)