After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779318 - Add grss-0.7 bindings
Add grss-0.7 bindings
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2017-02-27 15:24 UTC by Felipe Borges
Modified: 2017-03-02 08:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add grss-0.7 bindings (10.93 KB, patch)
2017-02-27 15:24 UTC, Felipe Borges 		none Details | Review
vapi: Add libgrss bindings (12.49 KB, patch)
2017-02-28 08:06 UTC, Rico Tzschichholz 		committed Details | Review

Description Felipe Borges 2017-02-27 15:24:10 UTC 
LibGRSS is a library for easy management of RSS/Atom/Pie feeds.
Includes methods to fetch, parse and handle XML documents, an implementation of PubSubHubBub client, an OPML parser and some more utility.

See: https://wiki.gnome.org/Projects/Libgrss
Comment 1 Felipe Borges 2017-02-27 15:24:33 UTC 
Created attachment 346830 [details] [review]
Add grss-0.7 bindings

The grss-0.7 bindings are slightly modified from the generated
VAPI:

 - The generated vapi file referenced "Grss-0.7.h" for the headers
instead of "libgrss/libgrss.h".
 - The generated vapi file referenced ibxml2 xmlDocPtr instead of
Xml.Doc.
Comment 2 Rico Tzschichholz 2017-02-27 15:34:52 UTC 
It would be way better if upstream would add and install it.
Comment 3 Rico Tzschichholz 2017-02-27 15:35:50 UTC 
Meaning to generate it from their gir on buildtime.
Comment 4 Al Thomas 2017-02-27 17:03:11 UTC 
(In reply to Felipe Borges from comment #1)
>  - The generated vapi file referenced "Grss-0.7.h" for the headers
> instead of "libgrss/libgrss.h".

The GIR is missing <c:include name="libgrss/libgrss.h"/>
It looks like this is added using an option with g-ir-scanner. Add the option:
--c-include="libgrss/libgrss.h"
when generating the GIR.

For an example on another project see:
https://bugs.freedesktop.org/show_bug.cgi?id=31291
Comment 5 Daniel Espinosa 2017-02-27 17:21:50 UTC 
For libxml2 issue see substitutions in GDA:

https://git.gnome.org/browse/libgda/tree/libgda/Gda-6.0.metadata
Comment 6 Rico Tzschichholz 2017-02-28 08:06:15 UTC 
Created attachment 346887 [details] [review]
vapi: Add libgrss bindings
Comment 7 Rico Tzschichholz 2017-03-02 08:32:40 UTC 
commit 0ee89e8696393668cb927d0b02d8ea199d30d6e5
Author: Rico Tzschichholz <ricotz@ubuntu.com>
Date:   Tue Feb 28 09:00:24 2017 +0100

    vapi: Add libgrss bindings